On Thu, May 28, 2020 at 12:05 PM Dennis YC Hsieh <dennis-yc.hsieh@xxxxxxxxxxxx> wrote: > > This patch support gce on mt6779 platform. > > Change since v5: > - spearate address shift code in client helper and mailbox controller > - separate write_s/write_s_mask and write_s_value/write_s_mask_value so that > client can decide use mask or not > - fix typo in header > > Change since v4: > - do not clear disp event again in drm driver > - symbolize value 1 to jump relative > > [... snip ...] > > > > Dennis YC Hsieh (16): > dt-binding: gce: add gce header file for mt6779 > mailbox: cmdq: variablize address shift in platform > mailbox: cmdq: support mt6779 gce platform definition > mailbox: mediatek: cmdq: clear task in channel before shutdown > soc: mediatek: cmdq: return send msg error code > soc: mediatek: cmdq: add address shift in jump > soc: mediatek: cmdq: add assign function > soc: mediatek: cmdq: add write_s function > soc: mediatek: cmdq: add write_s_mask function > soc: mediatek: cmdq: add read_s function > soc: mediatek: cmdq: add write_s value function > soc: mediatek: cmdq: add write_s_mask value function > soc: mediatek: cmdq: export finalize function > soc: mediatek: cmdq: add jump function > soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api > soc: mediatek: cmdq: add set event function > > .../devicetree/bindings/mailbox/mtk-gce.txt | 8 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +- > drivers/mailbox/mtk-cmdq-mailbox.c | 101 ++++++-- > drivers/soc/mediatek/mtk-cmdq-helper.c | 163 ++++++++++++- > include/dt-bindings/gce/mt6779-gce.h | 222 ++++++++++++++++++ > include/linux/mailbox/mtk-cmdq-mailbox.h | 10 +- > include/linux/soc/mediatek/mtk-cmdq.h | 125 +++++++++- > Please break the patchset into two. The lower mailbox related changes with soc changes on top. thanks