Hi Rob, On Sat, May 23, 2020 at 1:47 AM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > > On Fri, May 22, 2020 at 4:42 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Fri, 22 May 2020 14:33:10 +0300, Tali Perry wrote: > > > Added device tree binding documentation for Nuvoton BMC > > > NPCM I2C controller. > > > > > > Signed-off-by: Tali Perry <tali.perry1@xxxxxxxxx> > > > --- > > > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 60 +++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Error: Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.example.dts:22.28-29 syntax error > > FATAL ERROR: Unable to parse input tree > > scripts/Makefile.lib:312: recipe for target 'Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.example.dt.yaml' failed > > make[1]: *** [Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.example.dt.yaml] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > Makefile:1300: recipe for target 'dt_binding_check' failed > > make: *** [dt_binding_check] Error 2 > > > > See https://patchwork.ozlabs.org/patch/1296162 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > Please check and re-submit. > > Why do you keep sending new versions with the same problem? It won't > get reviewed until this is fixed. This isn't a free automated service > to throw things at to see if they work. I have to review the failures. > > Rob Definitely not trying to use the Bot to check my yaml. On the first version the dt-check was not updated on my side. On the previous version I updated according to the bot explanations. Found an error and fixed it. Now I don't see any errors. with latest dt-check. I did: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade make dt_binding_check And got a clean log, no warnings or errors. Was I suppose to check anything else? Thanks, Tali
