On Wed, May 20, 2020 at 08:40:24PM +0200, Thomas Bogendoerfer wrote: > On Wed, May 20, 2020 at 02:59:26PM +0300, Serge Semin wrote: > > I think there is a misunderstanding here. In this patch I am not enabling > > you are right, I've missed the fact, that this also needs to be enabled > in TLB entries. Strange that MIPS added the enable bit while R10k simply > do uncached acclerated, whenever TLB entry selects it. > > > If there is no misunderstanding and you said what you said, that even enabling > > the feature for utilization might be dangerous, let's at least leave the > > MIPS_CONF_MM, MIPS_CONF_MM_FULL and MIPS_CONF_MM_SYS_SYSAD fields > > definition in the "arch/mips/include/asm/mipsregs.h" header. I'll use > > them to enable the write-merge in my platform code. > > > > What do you think? > > I withdraw my concerns and will apply the patch as is. Great! Thanks. -Sergey > > Thomas. > > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ]
