On Thu, May 14, 2020 at 8:06 PM Ramuthevar, Vadivel MuruganX <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx> wrote: > > Hi Rob, > > Thank you for the review comments... > > On 14/5/2020 9:03 pm, Rob Herring wrote: > > On Wed, May 13, 2020 at 06:46:14PM +0800, Ramuthevar,Vadivel MuruganX wrote: > >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx> > >> > >> Add YAML file for dt-bindings to support NAND Flash Controller > >> on Intel's Lightning Mountain SoC. > >> > >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx> > >> --- > >> .../devicetree/bindings/mtd/intel,lgm-nand.yaml | 83 ++++++++++++++++++++++ > >> 1 file changed, 83 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml > >> + clocks = <&cgu0 125>; > >> + dma-names = "tx", "rx"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + #clock-cells = <1>; > > > > This is a clock provider too? > Yes, it is getting clock from CGU for nand-controller. That is a clock client (e.g. 'clocks' property), not a provider. The CGU is the provider. Rob