On Mon, Mar 09, 2020 at 01:07:28PM -0500, Rob Herring wrote: > On Fri, 6 Mar 2020 16:05:27 +0300, <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote: > > From: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > > > >From Linux point of view Baikal-T1 Boot Controller is a multi-function > > memory-mapped device, which provides an access to three memory-mapped > > ROMs and to an embedded DW APB SSI-based SPI controller. It's refelected > > in the be,bt1-boot-ctl bindings file. So the device must be added to > > the system dts-file as an ordinary memory-mapped device node with > > a single clocks source phandle declared and with also memory-mapped > > spi/mtd-rom sub-devices. > > > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > > Cc: Paul Burton <paulburton@xxxxxxxxxx> > > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > > --- > > .../bindings/mfd/be,bt1-boot-ctl.yaml | 89 +++++++++++++++++++ > > 1 file changed, 89 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/be,bt1-boot-ctl.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/mfd/be,bt1-boot-ctl.example.dts:17:10: fatal error: dt-bindings/clock/bt1-ccu.h: No such file or directory > #include <dt-bindings/clock/bt1-ccu.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/mfd/be,bt1-boot-ctl.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/mfd/be,bt1-boot-ctl.example.dt.yaml] Error 1 > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1250277 > Please check and re-submit. Rob, I'll fix this and also take into account the comments you added to the hwmon patch. Then I'll resend this patchset. So don't bother with review for now. Regards, -Sergey
