On 3/3/2020 6:09 PM, Andy Shevchenko wrote: > On Tue, Mar 03, 2020 at 11:37:23AM +0800, Tanwar, Rahul wrote: >> On 27/2/2020 6:02 PM, Andy Shevchenko wrote: >>> On Thu, Feb 27, 2020 at 03:19:26PM +0800, Tanwar, Rahul wrote: >>>> On 19/2/2020 3:59 PM, Randy Dunlap wrote: >>>>> On 2/18/20 11:40 PM, Rahul Tanwar wrote: >>>>> >>>>>> +config CLK_LGM_CGU >>>>>> + depends on (OF && HAS_IOMEM) || COMPILE_TEST >>>>> This "depends on" looks problematic to me. I guess we shall see when >>>>> all the build bots get to it. >>>> At the moment, i am not able to figure out possible problems in this.. >>> COMPILE_TEST should be accompanied by non-generic dependency. >>> There is none. >>> >>> So, I quite agree with Randy. >> I see COMPILE_TEST is mostly ORed with ARCH_xx. How about below? >> >> depends on OF && HAS_IOMEM && (CONFIG_X86 || COMPILE_TEST) > How about to leave logical parts separately? > How is OF related to architecture? OF is not related to architecture. Driver depends on OF. In the past, many build/linker issues were reported due to OF & HAS_IOMEM dependencies in the code. Please see [1] & [2]. So to be safe this time, i am adding these dependencies here. > On top of that, is this code only for x86 for sure? > Yes, this is a totally new IP for x86 based SoC. No plans of using same IP/driver for any other arch based SoCs. [1] https://lkml.org/lkml/2019/12/3/613 [2] https://lkml.org/lkml/2019/12/11/1733
