On Thu, Feb 27, 2020 at 03:19:26PM +0800, Tanwar, Rahul wrote: > On 19/2/2020 3:59 PM, Randy Dunlap wrote: > > On 2/18/20 11:40 PM, Rahul Tanwar wrote: > >> +config CLK_LGM_CGU > >> + depends on (OF && HAS_IOMEM) || COMPILE_TEST > > This "depends on" looks problematic to me. I guess we shall see when > > all the build bots get to it. > > At the moment, i am not able to figure out possible problems in this.. COMPILE_TEST should be accompanied by non-generic dependency. There is none. So, I quite agree with Randy. > >> + select OF_EARLY_FLATTREE > > If OF is not set and HAS_IOMEM is not set, but COMPILE_TEST is set, > > I expect that this should not be attempting to select OF_EARLY_FLATTREE. > > > > Have you tried such a config combination? > > Agree, that would be a problem. I will change it to > > select OF_EARLY_FLATTREE if OF Nope, I think this is wrong work around. See above. -- With Best Regards, Andy Shevchenko
