On 2/18/20 11:40 PM, Rahul Tanwar wrote: > From: rtanwar <rahul.tanwar@xxxxxxxxx> > > Clock Generation Unit(CGU) is a new clock controller IP of a forthcoming > Intel network processor SoC named Lightning Mountain(LGM). It provides > programming interfaces to control & configure all CPU & peripheral clocks. > Add common clock framework based clock controller driver for CGU. > > Signed-off-by: Rahul Tanwar <rahul.tanwar@xxxxxxxxxxxxxxx> > --- > drivers/clk/Kconfig | 1 + > drivers/clk/x86/Kconfig | 8 + > drivers/clk/x86/Makefile | 1 + > drivers/clk/x86/clk-cgu-pll.c | 156 +++++++++++ > drivers/clk/x86/clk-cgu.c | 636 ++++++++++++++++++++++++++++++++++++++++++ > drivers/clk/x86/clk-cgu.h | 335 ++++++++++++++++++++++ > drivers/clk/x86/clk-lgm.c | 492 ++++++++++++++++++++++++++++++++ > 7 files changed, 1629 insertions(+) > create mode 100644 drivers/clk/x86/Kconfig > create mode 100644 drivers/clk/x86/clk-cgu-pll.c > create mode 100644 drivers/clk/x86/clk-cgu.c > create mode 100644 drivers/clk/x86/clk-cgu.h > create mode 100644 drivers/clk/x86/clk-lgm.c > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index bcb257baed06..43dab257e7aa 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -360,6 +360,7 @@ source "drivers/clk/sunxi-ng/Kconfig" > source "drivers/clk/tegra/Kconfig" > source "drivers/clk/ti/Kconfig" > source "drivers/clk/uniphier/Kconfig" > +source "drivers/clk/x86/Kconfig" > source "drivers/clk/zynqmp/Kconfig" > > endmenu Hi, > diff --git a/drivers/clk/x86/Kconfig b/drivers/clk/x86/Kconfig > new file mode 100644 > index 000000000000..2e2b9730541f > --- /dev/null > +++ b/drivers/clk/x86/Kconfig > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +config CLK_LGM_CGU > + depends on (OF && HAS_IOMEM) || COMPILE_TEST This "depends on" looks problematic to me. I guess we shall see when all the build bots get to it. > + select OF_EARLY_FLATTREE If OF is not set and HAS_IOMEM is not set, but COMPILE_TEST is set, I expect that this should not be attempting to select OF_EARLY_FLATTREE. Have you tried such a config combination? > + bool "Clock driver for Lightning Mountain(LGM) platform" > + help > + Clock Generation Unit(CGU) driver for Intel Lightning Mountain(LGM) > + network processor SoC. thanks. -- ~Randy
