On Thu, Feb 27, 2020 at 11:13:41AM -0600, Rob Herring wrote: > On Thu, Feb 27, 2020 at 3:52 AM Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote: > > > > Add a DT bindings document for the Marvell 10G driver, which will > > augment the generic ethernet PHY binding by having LED mode > > configuration. > > > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/net/marvell,10g.yaml | 31 +++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/marvell,10g.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/marvell,10g.yaml b/Documentation/devicetree/bindings/net/marvell,10g.yaml > > new file mode 100644 > > index 000000000000..da597fc5314d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/marvell,10g.yaml > > @@ -0,0 +1,31 @@ > > +# SPDX-License-Identifier: GPL-2.0+ > > Dual license new bindings please: > > (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/marvell,10g.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Marvell Alaska X family Ethernet PHYs > > + > > +maintainers: > > + - Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > > + > > +allOf: > > + - $ref: ethernet-phy.yaml# > > + > > +properties: > > + marvell,led-mode: > > + description: | > > + An array of one to four 16-bit integers to write to the PHY LED > > + configuration registers. > > This is for what to blink or turn on for? I thought we had something > generic for configuring PHY LEDs specifically? I see nothing in ethernet-phy.yaml. Yes, it configures which conditions cause the LED to illuminate and/or blink, what blink rate and polarity of the pin. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint16-array > > + - minItems: 1 > > + maxItems: 4 > > + > > +examples: > > + - | > > + ethernet-phy@0 { > > + reg = <0>; > > This needs to be under an 'mdio' node with #address-cells and > #size-cells set correctly. I wish these things were documented somewhere... I'm pretty sure this passed validation when I wrote it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
