Ühel kenal päeval, N, 08.05.2014 kell 22:04, kirjutas Boris BREZILLON: > On 08/05/2014 13:02, Lee Jones wrote: > >> The PRCM (Power/Reset/Clock Management) block exposes several subdevices > >> in different subsystems (clk, reset ...) > >> > >> Add basic support for the PRCM unit with clk (AR100, AHB0, and APB0 clks) > >> and reset controller subdevices. > >> > >> Other subdevices might be added later (if needed). > >> > >> Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> > >> --- > >> drivers/mfd/Kconfig | 8 +++ > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/sun6i-prcm.c | 151 +++++++++++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 160 insertions(+) > >> create mode 100644 drivers/mfd/sun6i-prcm.c > > [...] > > > >> +#include <linux/module.h> > >> +#include <linux/kernel.h> > >> +#include <linux/errno.h> > >> +#include <linux/err.h> > >> +#include <linux/spinlock.h> > >> +#include <linux/io.h> > >> +#include <linux/slab.h> > >> +#include <linux/mutex.h> > >> +#include <linux/completion.h> > >> +#include <linux/irq.h> > >> +#include <linux/jiffies.h> > >> +#include <linux/bitops.h> > >> +#include <linux/fs.h> > >> +#include <linux/of.h> > >> +#include <linux/of_irq.h> > >> +#include <linux/platform_device.h> > >> +#include <linux/uaccess.h> > >> +#include <linux/mfd/core.h> > > I'm pretty sure you don't need half of these. Please only add the > > ones you make use of. > > Sure (this is what happens when you copy/paste from another driver :-)) Also, alphabetic order would be nice. Päikest, Priit Laes :) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html