On 08/05/2014 13:02, Lee Jones wrote: >> The PRCM (Power/Reset/Clock Management) block exposes several subdevices >> in different subsystems (clk, reset ...) >> >> Add basic support for the PRCM unit with clk (AR100, AHB0, and APB0 clks) >> and reset controller subdevices. >> >> Other subdevices might be added later (if needed). >> >> Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> >> --- >> drivers/mfd/Kconfig | 8 +++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/sun6i-prcm.c | 151 +++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 160 insertions(+) >> create mode 100644 drivers/mfd/sun6i-prcm.c > [...] > >> +#include <linux/module.h> >> +#include <linux/kernel.h> >> +#include <linux/errno.h> >> +#include <linux/err.h> >> +#include <linux/spinlock.h> >> +#include <linux/io.h> >> +#include <linux/slab.h> >> +#include <linux/mutex.h> >> +#include <linux/completion.h> >> +#include <linux/irq.h> >> +#include <linux/jiffies.h> >> +#include <linux/bitops.h> >> +#include <linux/fs.h> >> +#include <linux/of.h> >> +#include <linux/of_irq.h> >> +#include <linux/platform_device.h> >> +#include <linux/uaccess.h> >> +#include <linux/mfd/core.h> > I'm pretty sure you don't need half of these. Please only add the > ones you make use of. Sure (this is what happens when you copy/paste from another driver :-)) > > [...] > >> + dev_info(&pdev->dev, "PRCM initialized\n"); > Please remove this from here. Okay. > > [...] > >> +static struct platform_driver sun6i_prcm_driver = { >> + .driver = { >> + .name = "sun6i-prcm", >> + .owner = THIS_MODULE, >> + .of_match_table = sun6i_prcm_dt_ids, >> + }, >> + .probe = sun6i_prcm_probe, > You need a .remove() call-back. This driver cannot be compiled as module (see the Kconfig definition) and the devices are not hotpluggable, as a result a probed device will never be removed. Do you still want me to implement the remove function ? > >> +}; >> +module_platform_driver(sun6i_prcm_driver); >> + >> +MODULE_AUTHOR("Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx>"); >> +MODULE_DESCRIPTION("Allwinner sun6i PRCM driver"); >> +MODULE_LICENSE("GPL v2"); -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html