Hi Andy,
On 12/12/2019 12:47 AM, Andy Shevchenko wrote:
On Wed, Dec 11, 2019 at 04:50:04PM -0800, Jae Hyun Yoo wrote:
On 12/11/2019 12:28 PM, Andy Shevchenko wrote:
On Wed, Dec 11, 2019 at 11:46:16AM -0800, Jae Hyun Yoo wrote:
Like in the previous patch...
(1)
I see. I'll simplify this function like below:
#include <linux/iopoll.h>
static inline int aspeed_peci_check_idle(struct aspeed_peci *priv)
{
u32 cmd_sts;
return readl_poll_timeout(priv->base + ASPEED_PECI_CMD,
cmd_sts,
!(cmd_sts & ASPEED_PECI_CMD_IDLE_MASK),
ASPEED_PECI_IDLE_CHECK_INTERVAL_USEC,
ASPEED_PECI_IDLE_CHECK_TIMEOUT_USEC);
}
Good for *this* case, but please fix all the rest accordingly.
Sure. Will do that.
Thanks,
Jae