Re: [PATCH v4 2/2] ARM: dts: aspeed: Adding Facebook Yosemite V2 BMC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mani,
Please submit patch version 5 and put review comments below (---) line like below. 
And send as a patch submission not replied to this email.

   The Yosemite V2 is a facebook multi-node server
    platform that host four OCP server. The BMC
    in the Yosemite V2 platform based on AST2500 SoC.
    
    This patch adds linux device tree entry related to
    Yosemite V2 specific devices connected to BMC SoC.

    Signed-off-by: Manikandan Elumalai <manikandan.hcl.ers.epl@xxxxxxxxx>
    Acked-by   : Andrew Jeffery <andrew@xxxxxxxx>
    Reviewed-by: Vijay Khemka <vkhemka@xxxxxx>
    ---
    ---     v5 - Spell and contributor name correction.
    ---          - License identifier changed to GPL-2.0-or-later.
    ---          - aspeed-gpio.h removed.
    ---          - FAN2 tacho channel changed.
    ---      v4 - Bootargs removed.
    ---      v3 - Uart1 Debug removed .
    ---      v2 - LPC and VUART removed .
    ---      v1 - Initial draft.

.../boot/dts/aspeed-bmc-facebook-yosemitev2.dts    | 148 +++++++++++++++++++++
     1 file changed, 148 insertions(+)
     create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts

Regards
-Vijay

On 12/12/19, 5:08 AM, "Manikandan Elumalai" <manikandan.hcl.ers.epl@xxxxxxxxx> wrote:

    The Yosemite V2 is a facebook multi-node server
    platform that host four OCP server. The BMC
    in the Yosemite V2 platform based on AST2500 SoC.
    
    This patch adds linux device tree entry related to
    Yosemite V2 specific devices connected to BMC SoC.
    
    --- Reviews summary
    --- v4[2/2] - Spell and contributor name correction.
    ---         - License identifier changed to GPL-2.0-or-later.
    ---         - aspeed-gpio.h removed.
    ---         - FAN2 tacho channel changed.
    ---      v4 - Bootargs removed.
    ---      v3 - Uart1 Debug removed .
    ---      v2 - LPC and VUART removed .
    ---      v1 - Initial draft.
    
    Signed-off-by: Manikandan Elumalai <manikandan.hcl.ers.epl@xxxxxxxxx>
    Acked-by   : Andrew Jeffery <andrew@xxxxxxxx>
    Reviewed-by: Vijay Khemka <vkhemka@xxxxxx>
    ---
     .../boot/dts/aspeed-bmc-facebook-yosemitev2.dts    | 148 +++++++++++++++++++++
     1 file changed, 148 insertions(+)
     create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
    
    diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
    new file mode 100644
    index 0000000..ffd7f4c
    --- /dev/null
    +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
    @@ -0,0 +1,148 @@
    +// SPDX-License-Identifier: GPL-2.0-or-later
    +// Copyright (c) 2018 Facebook Inc.
    +
    +/dts-v1/;
    +
    +#include "aspeed-g5.dtsi"
    +/ {
    +	model = "Facebook Yosemitev2 BMC";
    +	compatible = "facebook,yosemitev2-bmc", "aspeed,ast2500";
    +	aliases {
    +		serial4 = &uart5;
    +	};
    +	chosen {
    +		stdout-path = &uart5;
    +	};
    +
    +	memory@80000000 {
    +		reg = <0x80000000 0x20000000>;
    +	};
    +
    +	iio-hwmon {
    +		// VOLATAGE SENSOR
    +		compatible = "iio-hwmon";
    +		io-channels = <&adc 0> , <&adc 1> , <&adc 2> ,  <&adc 3> ,
    +		<&adc 4> , <&adc 5> , <&adc 6> ,  <&adc 7> ,
    +		<&adc 8> , <&adc 9> , <&adc 10>, <&adc 11> ,
    +		<&adc 12> , <&adc 13> , <&adc 14> , <&adc 15> ;
    +	};
    +};
    +
    +&fmc {
    +	status = "okay";
    +	flash@0 {
    +		status = "okay";
    +		m25p,fast-read;
    +#include "openbmc-flash-layout.dtsi"
    +	};
    +};
    +
    +&spi1 {
    +	status = "okay";
    +	pinctrl-names = "default";
    +	pinctrl-0 = <&pinctrl_spi1_default>;
    +	flash@0 {
    +		status = "okay";
    +		m25p,fast-read;
    +		label = "pnor";
    +	};
    +};
    +
    +&uart5 {
    +	// BMC Console
    +	status = "okay";
    +};
    +
    +&mac0 {
    +	status = "okay";
    +	pinctrl-names = "default";
    +	pinctrl-0 = <&pinctrl_rmii1_default>;
    +	use-ncsi;
    +};
    +
    +&adc {
    +	status = "okay";
    +	pinctrl-names = "default";
    +	pinctrl-0 = <&pinctrl_adc0_default
    +			&pinctrl_adc1_default
    +			&pinctrl_adc2_default
    +			&pinctrl_adc3_default
    +			&pinctrl_adc4_default
    +			&pinctrl_adc5_default
    +			&pinctrl_adc6_default
    +			&pinctrl_adc7_default
    +			&pinctrl_adc8_default
    +			&pinctrl_adc9_default
    +			&pinctrl_adc10_default
    +			&pinctrl_adc11_default
    +			&pinctrl_adc12_default
    +			&pinctrl_adc13_default
    +			&pinctrl_adc14_default
    +			&pinctrl_adc15_default>;
    +};
    +
    +&i2c8 {
    +	//FRU EEPROM
    +	status = "okay";
    +	eeprom@51 {
    +		compatible = "atmel,24c64";
    +		reg = <0x51>;
    +		pagesize = <32>;
    +	};
    +};
    +
    +&i2c9 {
    +	//INLET & OUTLET TEMP
    +	status = "okay";
    +	tmp421@4e {
    +		compatible = "ti,tmp421";
    +		reg = <0x4e>;
    +	};
    +	tmp421@4f {
    +		compatible = "ti,tmp421";
    +		reg = <0x4f>;
    +	};
    +};
    +
    +&i2c10 {
    +	//HSC
    +	status = "okay";
    +	adm1278@40 {
    +		compatible = "adi,adm1278";
    +		reg = <0x40>;
    +	};
    +};
    +
    +&i2c11 {
    +	//MEZZ_TEMP_SENSOR
    +	status = "okay";
    +	tmp421@1f {
    +		compatible = "ti,tmp421";
    +		reg = <0x1f>;
    +	};
    +};
    +
    +&i2c12 {
    +	//MEZZ_FRU
    +	status = "okay";
    +	eeprom@51 {
    +		compatible = "atmel,24c64";
    +		reg = <0x51>;
    +		pagesize = <32>;
    +	};
    +};
    +
    +&pwm_tacho {
    +	//FSC
    +	status = "okay";
    +	pinctrl-names = "default";
    +	pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default>;
    +	fan@0 {
    +		reg = <0x00>;
    +		aspeed,fan-tach-ch = /bits/ 8 <0x00>;
    +	};
    +	fan@1 {
    +		reg = <0x01>;
    +		aspeed,fan-tach-ch = /bits/ 8 <0x01>;
    +	};
    +};
    -- 
    2.7.4
    
    





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux