Thanks Linus, > > I sent a separate patch to fix this up the way I want it with the file named gpio-aspeed-sgpio.c and > CONFIG_GPIO_ASPEED_SGPIO. > > I don't want to mix up the namespaces of something Aspeed-generic with the namespace of the GPIO > subsystem. SGPIO is the name of a specific Aspeed component. > > Yours, > Linus Walleij I agree and gpio-aspeed-sgpio.c is better. Regards, --Hongwei