On 9/12/2019 11:50 AM, Marc Zyngier wrote:
On Thu, 12 Sep 2019 07:50:03 +0100,
"Shenhar, Talel" <talel@xxxxxxxxxx> wrote:
Hi Marc,
On 9/11/2019 5:15 PM, Marc Zyngier wrote:
[+James]
Hi Talel,
On Tue, 10 Sep 2019 20:05:09 +0100,
Talel Shenhar <talel@xxxxxxxxxx> wrote:
+ log1 = readl(pos->mmio_base + AL_POS_ERROR_LOG_1);
Do you actually need the implied barriers? I'd expect that relaxed
accesses should be enough.
You are correct. Barriers are not needed, In v1 this driver indeed
used _relaxed versions.
Due to request coming from Arnd in v1 patch series I removed it. As
this is not data path I had no strong objection for removing it.
Independently from whether this has any material impact on performance
(this obviously isn't a hot path, unless it can be directly generated
by userspace or a guest), I believe it is important to use the right
type of accessor, if only because code gets copied around... Others
would probably argue that this is the very reason why we should always
use the "safe" option...
Arnld, would love your inputs before publishing v3 to avoid ping-pong.
+ if (!FIELD_GET(AL_POS_ERROR_LOG_1_VALID, log1))
+ return IRQ_NONE;
+
+ log0 = readl(pos->mmio_base + AL_POS_ERROR_LOG_0);
+ writel(0, pos->mmio_base + AL_POS_ERROR_LOG_1);
+
+ addr = FIELD_GET(AL_POS_ERROR_LOG_0_ADDR_LOW, log0);
+ addr |= (FIELD_GET(AL_POS_ERROR_LOG_1_ADDR_HIGH, log1) << 32);
+ request_id = FIELD_GET(AL_POS_ERROR_LOG_1_REQUEST_ID, log1);
+ bresp = FIELD_GET(AL_POS_ERROR_LOG_1_BRESP, log1);
+
+ dev_err(&pdev->dev, "addr=0x%llx request_id=0x%x bresp=0x%x\n",
+ addr, request_id, bresp);
What is this information? How do we make use of it? Given that this is
asynchronous, how do we correlate it to the offending software?
Indeed this information arriving from the HW is asynchronous.
There is no direct method to get the offending software.
There are all kinds of hacks we do to find the offending software once
we find this error. most of the time its a new patch introduced but
some of the time is just digging.
OK, so that the moment, this is more of a debug tool than anything
else, right?
Not sure what do you mean by debug tool. this is used to capture iliigle
access and allow panic() based on them or simple logging.
The whole think looks to me like a poor man's EDAC handling, and I'd
expect to be plugged in that subsystem instead. Any reason why this
isn't the case? It would certainly make the handling uniform for the
user.
This logic was not plugged into EDAC as there is no "Correctable"
error here. its just error event. Not all errors are EDAC in the sense
of Error Detection And *Correction*. There are no correctable errors
for this driver.
I'd argue the opposite! Because you obviously don't let a read-only
register being written to, the error has been corrected, and you
signal the correction status.
Not the meaning of corrected from my point of view - the system as a
whole (sw&hw) are not working state. a driver thinks it configured the
system to do A while the system doesn't really do that. and the critical
part is that the driver that did operation A doesn't even have a way to
know it.
So I would not call this corrected.
So plugging it under EDAC seems like abusing the EDAC system.
Now that I've emphasize the reason for not putting this under EDAC,
what do you think? should this "only uncorrectable event" driver
should be part of EDAC?
My choice would be to plug it into the EDAC subsystem, and report all
interrupts as "Corrected" events. Optionally, and only if you are
debugging something that requires it, report the error as
"Uncorrectable", in which case the EDAC subsystem should trigger a
panic.
At least you'd get the infrastructure, logging and tooling that the
EDAC subsystem offers (parsing the kernel log doesn't really count).
I see what you say. However, I don't see too much added value in
plugging this to EDAC and feel like it would abuse EDAC framework.
James, will love your input from EDAC point of view, does it make sense
to plug un-correctable only event to EDAC?
Thanks,
M.
