On Wed, 11 Sep 2019 at 13:57, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > > Hi Krzyszotf, > > On 2019-09-11 13:36, Krzysztof Kozlowski wrote: > > On Wed, 11 Sep 2019 at 13:05, Maciej Falkowski <m.falkowski@xxxxxxxxxxx> wrote: > >> Convert Samsung Exynos IOMMU H/W, System Memory Management Unit > >> to newer dt-schema format. > >> > >> Update clock description. > >> > >> Signed-off-by: Maciej Falkowski <m.falkowski@xxxxxxxxxxx> > >> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > >> --- > >> Hi Krzysztof, > >> > >> Thank you for feedback. > >> > >> v3: > >> > >> - remove obsolete interrupts description and > >> set its maxItems to one. There are some incompatible > >> files which will be fixed with another patch. > > Driver stopped supporting two IRQ lines in commit > > 7222e8db2d506197ee183de0f9b76b3ad97e8c18 (iommu/exynos: Fix build > > errors). The second IRQ line in Exynos3250 DTS seems to be ignored. > > > > The patch now looks good to me: > > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > > > However for some reasons you did not CC the IOMMU maintainers. Please > > use scripts/get_maintainer.pl to get the list of folks to CC. > > Frankly I don't see any reason to spam IOMMU ml or maintainer with this > discussion about dt-binding conversion. This patch will be merged via dt > tree if I got it right. Indeed usually subsystem maintainers are not interested in DT schema conversion although they are mentioned as maintainers for this file so it is nice to CC them... I would not call spamming when there is explicit pattern for CCing. Best regards, Krzysztof