Hi Anand, On Sun, Sep 1, 2019 at 3:58 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote: > > Hi Martin, > > Thanks for your review comments. > > Their have been some revision changes in S905 Odroid Schematics. > [0] https://dn.odroid.com/S905/Schematic/ > > Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf [...] > > > > according to the schematics there's both: > > - VDDIO_AO3V3 > > - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > > > > From the schematics it seams same. > > VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3 yes, they are the same signal. the only difference is that VCC3V3 is turned on later in the power-up sequence > But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC > > VDDIO_AO3V3-----TFLASH_VDD using TFLASH_VDD_EN gpio pin. > > Well I have tested this changes on eMMC module. I cannot see any of the TFLASH_* regulators being linked to eMMC (they are only linked to the SD card slot, I also checked odroid-c2_rev0.2_20151218.pdf and odroid-c2_rev0.2_20171114.pdf). which page of the odroid-c2_rev0.2_20151218.pdf schematics shows how TFLASH_VDD is linked to eMMC? please note that I don't have an Odroid-C2 board myself (so I cannot test any of this). Martin
