Hi Martin, Thanks for your review comments. Their have been some revision changes in S905 Odroid Schematics. [0] https://dn.odroid.com/S905/Schematic/ Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf On Sun, 1 Sep 2019 at 17:07, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: > > On Wed, Aug 28, 2019 at 10:27 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote: > > > > As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC: > typo: "schematics" > OK. next time will run spell check before I send these changes. > > fixed regulator output which is supplied by P5V0. > > > > Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics. > typo: "schematics" Ok. > > according to the schematics there's both: > - VDDIO_AO3V3 > - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > >From the schematics it seams same. VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3 But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC VDDIO_AO3V3-----TFLASH_VDD using TFLASH_VDD_EN gpio pin. Well I have tested this changes on eMMC module. > > Cc: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > > Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > --- > > .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +++++++++++++++++-- > > 1 file changed, 26 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > index 792698a60a12..98e742bf44c1 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > @@ -104,11 +104,34 @@ > > regulator-max-microvolt = <1800000>; > > }; > > > > - vcc3v3: regulator-vcc3v3 { > > + vddio_ao1v8: regulator-vddio-ao1v8 { > > compatible = "regulator-fixed"; > > - regulator-name = "VCC3V3"; > > + regulator-name = "VDDIO_AO1V8"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-always-on; > > + /* U17 RT9179GB */ > > + vin-supply = <&p5v0>; > > + }; > > + > > + vddio_ao3v3: regulator-vddio-ao3v3 { > > + compatible = "regulator-fixed"; > > + regulator-name = "VDDIO_AO3V3"; > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + /* U11 MP2161GJ-C499 */ > > + vin-supply = <&p5v0>; > > + }; > > + > > + vddc_ddr: regulator-vddc-ddr { > > + compatible = "regulator-fixed"; > > + regulator-name = "DDR_VDDC"; > personally I would call this (along with the node name and alias) DDR3_1V5 > odroid-c2_rev0.1_20150930.pdf shows that DDR3_1V5 and DDR_VDDC are > both the same. however, the DDR_VDDC signal name is not used by any > component in the datasheet Ok Thanks I will change this to DDR3_1V5 as per the datasheet. > > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <1500000>; > > + regulator-always-on; > > + /* U15 MP2161GJ-C499 */ > > + vin-supply = <&p5v0>; > > }; > > > > emmc_pwrseq: emmc-pwrseq { > > @@ -301,7 +324,7 @@ > > mmc-hs200-1_8v; > > > > mmc-pwrseq = <&emmc_pwrseq>; > > - vmmc-supply = <&vcc3v3>; > > + vmmc-supply = <&vddio_ao3v3>; > odroid-c2_rev0.1_20150930.pdf uses VCC3V3 as supply > > > Martin Best Regards -Anand
