On Tue, Jul 16, 2019 at 12:37 PM Dong Aisheng <aisheng.dong@xxxxxxx> wrote: > + uart0_lpcg: clock-controller@5a460000 { > + reg = <0x5a460000 0x10000>; > + #clock-cells = <1>; > + clocks = <&clk IMX_ADMA_UART0_CLK>, > + <&dma_ipg_clk>; Putting the clocks into a single line helps readability, even if it is over 80 col. > + bit-offset = <0 16>; > + clock-output-names = "uart0_lpcg_baud_clk", > + "uart0_lpcg_ipg_clk"; Same here.