On Wed, Jul 3, 2019 at 4:08 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > On Wed, Jul 03, 2019 at 11:33:27PM +0200, Andrew Lunn wrote: > > > I think if we're going to have custom properties for phys, we should > > > have a compatible string to at least validate whether the custom > > > properties are even valid for the node. > > > > Hi Rob > > > > What happens with other enumerable busses where a compatible string is > > not used? > > > > The Ethernet PHY subsystem will ignore the compatible string and load > > the driver which fits the enumeration data. Using the compatible > > string only to get the right YAML validator seems wrong. I would > > prefer adding some other property with a clear name indicates its is > > selecting the validator, and has nothing to do with loading the > > correct driver. And it can then be used as well for USB and PCI > > devices etc. > > I also have doubts whether a compatible string is the right answer > here. It's not needed/used by the subsystem, but would it be a > required property because it's needed for validation? It could be required only for phy's with vendor specific properties.
