On Wed, Jul 3, 2019 at 3:33 PM Andrew Lunn <andrew@xxxxxxx> wrote: > > > I think if we're going to have custom properties for phys, we should > > have a compatible string to at least validate whether the custom > > properties are even valid for the node. > > Hi Rob > > What happens with other enumerable busses where a compatible string is > not used? We usually have a compatible. USB and PCI both do. Sometimes it is a defined format based on VID/PID. > The Ethernet PHY subsystem will ignore the compatible string and load > the driver which fits the enumeration data. Using the compatible > string only to get the right YAML validator seems wrong. I would > prefer adding some other property with a clear name indicates its is > selecting the validator, and has nothing to do with loading the > correct driver. And it can then be used as well for USB and PCI > devices etc. Just because Linux happens to not use compatible really has nothing to do with whether or not the nodes should have a compatible. What does FreeBSD want? U-boot? I don't follow how adding a validate property would help. It would need to be 'validate-node-as-a-realtek-phy'. The schema selection is done for each schema on a node by node basis and has to be based on some data in the node (or always applied). Using compatible or node name are just the default way. Rob
