-----Original Message----- From: Linus Walleij <linus.walleij@xxxxxxxxxx> Sent: Monday, June 3, 2019 7:08 PM To: Hongwei Zhang <Hongweiz@xxxxxxx> Cc: Joel Stanley <joel@xxxxxxxxx>; Andrew Jeffery <andrew@xxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; open list:GPIO SUBSYSTEM <linux-gpio@xxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH linux dev-5.1 v1] ARM: dts: aspeed: Add SGPM pinmux Hi Hongwei, On Tue, Jun 4, 2019 at 12:44 AM Hongwei Zhang <hongweiz@xxxxxxx> wrote: > > Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for > supporting SGPIO in AST2500 SoC. > > Signed-off-by: Hongwei Zhang <hongweiz@xxxxxxx> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 2 +- > arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++ > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 4 ++++ Please try to separate out the change to arch/arm/boot/dts/aspeed-g5.dtsi into a separate patch that goes through ARM SoC. Just committed the DT patch to _https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git , please help to review. Thanks! Other than that it looks fine to me. Yours, Linus Walleij
