Hi Hongwei, On Tue, Jun 4, 2019 at 12:44 AM Hongwei Zhang <hongweiz@xxxxxxx> wrote: > > Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for > supporting SGPIO in AST2500 SoC. > > Signed-off-by: Hongwei Zhang <hongweiz@xxxxxxx> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 2 +- > arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++ > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 4 ++++ Please try to separate out the change to arch/arm/boot/dts/aspeed-g5.dtsi into a separate patch that goes through ARM SoC. Other than that it looks fine to me. Yours, Linus Walleij
