Re: [PATCH] clk: ti: clkctrl: Fix returning uninitialized data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/05/2019 09:55, Tony Lindgren wrote:
If we do a clk_get() for a clock that does not exists, we have
_ti_omap4_clkctrl_xlate() return uninitialized data if no match
is found. This can be seen in some cases with SLAB_DEBUG enabled:

Unable to handle kernel paging request at virtual address 5a5a5a5a
...
clk_hw_create_clk.part.33
sysc_notifier_call
notifier_call_chain
blocking_notifier_call_chain
device_add

Let's fix this by setting a found flag only when we find a match.

Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
Reported-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
Fixes: 88a172526c32 ("clk: ti: add support for clkctrl clocks")
Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
---
  drivers/clk/ti/clkctrl.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

I can boot again with this fix, thanks!

Tested-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux