On Tue, Apr 8, 2014 at 7:44 PM, Scott Wood <scottwood@xxxxxxxxxxxxx> wrote: > On Tue, 2014-03-25 at 14:41 +0100, Valentin Longchamp wrote: >> These are the bindings for 2 MFD devices used on some of the Keymile boards. >> The first one is the chassis managmenet bfticu FPGA. >> The second one is the board controller (reset, LEDs, GPIOs) QRIO CPDL. >> These FPGAs are used in the kmcoge4 board. >> >> This patch also add KEYMILE to the vendor-prefixes. You can drop the keymile addition. I have that queued up. [snip] >> +Required properties: >> +- compatible: "keymile,bfticu" >> +- interrupt-controller: the bfticu FPGA is an interrupt controller >> +- interrupts: the main IRQ line to signal the collected IRQs >> +- #interrupt-cells : is 2 >> + - The 1st cell is the local IRQ number on the bfticu >> + - The 2nd cell is the type of the IRQ (IRQ_TYPE_xxx) > > Device tree bindings should not depend on the content of Linux headers. > One is stable ABI, and the other isn't. > > If you want you can make the values the same for convenience, as is done > by IPIC, CPM PIC, etc -- but the values need to be explicitly stated in > the binding. It'll still break if the Linux values change (so it may > not be a good idea to try to keep the values the same), but at least the > fix would be in Linux code rather than an ABI change. You can simply refer to Documentation/devicetree/bindings/interrupt-controller/interrupts.txt. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
