On 23.05.19 10:43, Shawn Guo wrote: > On Thu, May 16, 2019 at 11:47:04AM +0000, Kuldeep Singh wrote: >> QSPI support is added for kernel version greater than 5.0 and supports >> quad mode defined by >> TX-WIDTH = <4>, RX-WIDTH = <4> >> >> RDB/QDS has one 64MB flash from SPANSION(s25fs512s) >> >> Signed-off-by: Ashish Kumar <ashish.kumar@xxxxxxx> >> Signed-off-by: Kuldeep Singh <kuldeep.singh@xxxxxxx> >> --- >> Dependency on https://patchwork.ozlabs.org/patch/1100471/ >> Dependency on https://patchwork.ozlabs.org/patch/1100472/ >> >> .../arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 15 +++++++++++++++ >> .../arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts | 15 +++++++++++++++ >> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 15 +++++++++++++++ >> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 15 +++++++++++++++ >> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15 +++++++++++++++ >> 5 files changed, 75 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts >> index f90c040fd5e8..8826278b37bf 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts >> @@ -61,6 +61,21 @@ >> status = "okay"; >> }; >> >> +&qspi { > > Please sort these labeling nodes alphabetically. That said, &qspi > should go after &i2c0. > >> + status = "okay"; >> + >> + qflash0: flash@0 { >> + compatible = "spansion,m25p80", "jedec,spi-nor"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + m25p,fast-read; >> + spi-max-frequency = <20000000>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <4>; >> + reg = <0>; >> + }; >> +}; >> + >> &i2c0 { >> status = "okay"; >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts >> index 8749634c55ee..0246e8c97628 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts >> @@ -20,6 +20,21 @@ >> status = "okay"; >> }; >> >> +&qspi { >> + status = "okay"; >> + >> + qflash0: flash@0 { >> + compatible = "spansion,m25p80", "jedec,spi-nor"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + m25p,fast-read; >> + spi-max-frequency = <20000000>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <4>; >> + reg = <0>; >> + }; >> +}; >> + >> &i2c0 { >> status = "okay"; >> }; >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts >> index 2fb1cb1f7d8f..c304fa20c1c9 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts >> @@ -90,6 +90,21 @@ >> }; >> }; >> >> +&qspi { >> + status = "okay"; >> + >> + qflash0: flash@0 { >> + compatible = "spansion,m25p80", "jedec,spi-nor"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + m25p,fast-read; >> + spi-max-frequency = <20000000>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <4>; >> + reg = <0>; >> + }; >> +}; >> + >> &duart0 { >> status = "okay"; >> }; >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts >> index 5edb1e137a52..6017e9cfe40a 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts >> @@ -38,3 +38,18 @@ >> &sata { >> status = "okay"; >> }; >> + >> +&qspi { >> + status = "okay"; >> + >> + qflash0: flash@0 { >> + compatible = "spansion,m25p80", "jedec,spi-nor"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + m25p,fast-read; >> + spi-max-frequency = <20000000>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <4>; >> + reg = <0>; >> + }; >> +}; >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi >> index ec6257a5b251..268268c6a149 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi >> @@ -350,6 +350,21 @@ >> status = "disabled"; >> }; >> >> + qspi: spi@1550000 { > > Please sort node with unit-address in that address. That said, it > should go before esdhc@1560000. > >> + compatible = "fsl,ls1021a-qspi", "fsl,ls1012a-qspi"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0x0 0x1550000 0x0 0x10000>, >> + <0x0 0x40000000 0x0 0x10000000>; >> + reg-names = "QuadSPI", "QuadSPI-memory"; >> + interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>; >> + clock-names = "qspi_en", "qspi"; >> + clocks = <&clockgen 4 1>, <&clockgen 4 1>; >> + big-endian; >> + fsl,qspi-has-second-chip; > > Undocumented property? Both properties, "fsl,qspi-has-second-chip" and "big-endian" are deprecated. See: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=78df30808961cd32f0517c7469886386b0680852
