Hi Miquel, > > > > > > + > > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int chipnr) > > > > > > _select_target() is preferred now > > > > Do you mean I implement mxic_nand_select_target() to control #CS ? > > > > If so, I need to call mxic_nand_select_target( ) to control #CS ON > > and then #CS OFF in _exec_op() due to nand_select_target()<in nand_base,c> > > is still calling chip->legacy.select_chip ? > > You must forget about the ->select_chip() callback. Now it should be > handled directly from the controller driver. Please have a look at the > commit pointed against the marvell_nand.c driver. I have no Marvell NFC datasheet and have one question. In marvell_nand.c, there is no xxx_deselect_target() or something like that doing #CS OFF. marvell_nfc_select_target() seems always to make one of chip or die #CS keep low. Is it right ? How to make all #CS keep high for NAND to enter low-power standby mode if driver don't use "legacy.select_chip()" ? thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
