On Sun, May 19, 2019 at 04:22:39PM +0200, Ondřej Jirman wrote: > On Sat, May 18, 2019 at 12:34:57AM +0800, Frank Lee wrote: > > HI, > > > > On Fri, May 17, 2019 at 2:29 AM Ondřej Jirman <megous@xxxxxxxxxx> wrote: > > > > > > Hi Yangtao, > > > > > > thank you for work on this driver. > > > > > > On Fri, May 17, 2019 at 02:06:53AM +0800, Frank Lee wrote: > > > > HI Ondřej, > > > > > > > > On Mon, May 13, 2019 at 6:16 AM Ondřej Jirman <megous@xxxxxxxxxx> wrote: > > > > > > + > > > > > > +/* Temp Unit: millidegree Celsius */ > > > > > > +static int tsens_reg2temp(struct tsens_device *tmdev, > > > > > > + int reg) > > > > > > > > > > Please name all functions so that they are more clearly identifiable > > > > > in stack traces as belonging to this driver. For example: > > > > > > > > > > sun8i_ths_reg2temp > > > > > > > > > > The same applies for all tsens_* functions below. tsens_* is too > > > > > generic. > > > > > > > > Done but no sun8i_ths_reg2temp. > > > > > > > > ths_reg2tem() should be a generic func. > > > > I think it should be suitable for all platforms， so no platform prefix. > > > > > > You've missed my point. The driver name is sun8i_thermal and if you get > > > and oops from the kernel you'll get a stack trace where there are just function > > > names. If you use too generic function names, it will not be clear which > > > driver is oopsing. > > > > > > - sun8i_ths_reg2temp will tell you much more clearly where to search than > > > - ths_reg2temp > > > > > > Of course you can always grep, but most thermal drivers are thermal sensor (ths) > > > drivers, and if multiple of them used this too-generic naming scheme you'd > > > have hard time debugging. > > > > > > Look at other thermal drivers. They usually encode driver name in the function > > > names to help with identification (even if these are static driver-local > > > functions). > > > > > > > Can we change to sunxi_ths_ prefix? > > It should probably match the driver name, but yes, that's better. Not really. This driver will not support all the Allwinner devices, so sunxi is seriously misleading. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
