Hi Shimodaさん > From: Yoshihiro Shimoda > Sent: Friday, May 10, 2019 7:00 AM > I have submitted such a patch as following: > https://patchwork.kernel.org/patch/10938575/ OK. I will rebase my patches on top of your patch. I will say my patch series depends on your patch. > About SoC parameters, I think it is better to add members into struct > renesas_usbhs_driver_param like > has_usb_dmac instead of USBHSF_* definitions. In other words, we don't > need the patch 08/15 and > patch 09/15 and 10/15 should add each member for it. Chris-san, what do > you think? I think that is good. New Patch 08/15: * Add to struct renesas_usbhs_driver_param: u32 has_runtime_pwctrl:1; * Remove USBHSF_* * Remove usbhsc_flags_* New Patch 09/15: * Add to struct renesas_usbhs_driver_param: u32 has_cnen:1; New Patch 10/15: * Add to struct renesas_usbhs_driver_param: u32 cfifo_byte_addr:1; Chris