RE: [PATCH v2 11/15] usb: renesas_usbhs: Add support for RZ/A2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san, Chris-san,

> From: Yoshihiro Shimoda, Sent: Friday, May 10, 2019 5:16 PM
> 
> Hi Geert-san,
> 
> > From: Geert Uytterhoeven, Sent: Friday, May 10, 2019 4:07 PM
> >
> > Hi Chris,
> >
> > On Thu, May 9, 2019 at 10:14 PM Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> <snip>
> > BTW, this driver uses a mix of feature checking using USBHS_TYPE_*
> > enums, and a parameter block/callback struct
> > (renesas_usbhs_platform_callback).  Perhaps the feature flags can just
> > be moved to the struct, and the various structs referenced from
> > of_device_id.data?
> 
> Thank you for your comment! I think so. So, I'll make such a patch later.

I have submitted such a patch as following:
https://patchwork.kernel.org/patch/10938575/

Since usbhsc_is_multi_clks() uses the type member, each struct also has the type like previous code.

About SoC parameters, I think it is better to add members into struct renesas_usbhs_driver_param like
has_usb_dmac instead of USBHSF_* definitions. In other words, we don't need the patch 08/15 and
patch 09/15 and 10/15 should add each member for it. Chris-san, what do you think?

Best regards,
Yoshihiro Shimoda

> Best regards,
> Yoshihiro Shimoda
> 
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux