Hi Geert, On Tue, May 07, 2019, Geert Uytterhoeven wrote: > > + if (of_property_read_bool(dev->of_node, "renesas,uses_usb_x1")) > > + channel->uses_usb_x1 = true; > > + > > Perhaps this can be checked some other way (e.g. by checking for a non- > zero > clock rate of the USB_X1 clock referenced from DT), thus removing the need > for > adding a custom property? Currently, there is no USB_X1 in DT like there is for RZ/A1. For RZ/A2, those are dedicated pins that belong to the USB HW block itself. They do not feed into the system CPG or any dividers, so I never included it in the .dtsi. So with that said, does a uses-usb-x1 property make more sense? Chris