Hi Chris, On Tue, May 7, 2019 at 1:47 AM Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote: > The RZ/A2 has optional dedicated 48MHz crystal inputs, which adds a new > register setting when used. > > Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx> Thanks for your patch! > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > @@ -630,6 +635,9 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) > } > } > > + if (of_property_read_bool(dev->of_node, "renesas,uses_usb_x1")) > + channel->uses_usb_x1 = true; > + Perhaps this can be checked some other way (e.g. by checking for a non-zero clock rate of the USB_X1 clock referenced from DT), thus removing the need for adding a custom property? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds