On 5/5/19 8:57 PM, Jonas Gorski wrote: > Hi Philippe, > > On Fri, 3 May 2019 at 16:36, Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> wrote: >> >> Hi Jonas, >> >> On 5/2/19 2:26 PM, Jonas Gorski wrote: >>> Add binding documentation for the gated clock controller found on MIPS >>> based BCM63XX SoCs. >> >> I'd have ordered this patch after the #2 of this series, or eventually >> squashed both together. It is weird to document an unexistant feature >> then implement it, while the opposite looks more natural. >> (If you agree, maybe Paul can invert those when applying this series). >> >> Anyway: >> Reviewed-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> > > You are documenting hardware, not a driver/feature. :-) > > The binding is supposed to be a separate patch [1]. The natural order > is to first describe the hardware (with the binding documentation), > then add the actual driver making use of the binding. Checkpatch.pl > will also warn if you use a compatible that isn't documented, which > happens (shortly) if you first add the driver. Oh, thanks for the pointer, this is my first DT review ;) > Regards > Jonas > > [1] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/submitting-patches.txt#L8 >
