Re: [PATCH v2 1/2] dt-bindings: mtd: Add YAML schemas for the generic NAND options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On Tue, Apr 02, 2019 at 08:20:58PM -0500, Rob Herring wrote:
> > +      nand-ecc-strength:
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +        minimum: 1
>
> While I wished this worked, these 2 have to be under 'allOf'.
> Unfortunately, this will also silently pass validation in json-schema.

Unfortunately, I'm not sure I fully get how the ref system is supposed
to work yet. Can you elaborate a bit on why we should put the ref and
whatever constraint we have in an allOf?

Should we do the same in a separate schema that would reference
another entire schema (like the second patch does with the first
one)?

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux