On Wed, Apr 3, 2019 at 2:35 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > Hi Rob, > > On Tue, Apr 02, 2019 at 08:20:58PM -0500, Rob Herring wrote: > > > + nand-ecc-strength: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + minimum: 1 > > > > While I wished this worked, these 2 have to be under 'allOf'. > > Unfortunately, this will also silently pass validation in json-schema. > > Unfortunately, I'm not sure I fully get how the ref system is supposed > to work yet. Can you elaborate a bit on why we should put the ref and > whatever constraint we have in an allOf? TL;DR is that is how sub-classing or extending schemas works. I think I read something at one point which explained why it doesn't work without allOf, but couldn't find it. Certainly, it seems like it should at first. > Should we do the same in a separate schema that would reference > another entire schema (like the second patch does with the first > one)? That would just split defining the type from the additional constraints. I prefer to keep the top-level 'allOf' including classes of devices. Rob
