Re: [PATCH 1/2] dt-bindings: display: tfp410: Add bus-width parameter property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Peter,

Thank you for the patch.

On Mon, Apr 01, 2019 at 03:41:42PM +0300, Peter Ujfalusi wrote:
> tfp410 can be connect to host processor in 24bit, single-edge (24 lines) or
> 12bit, dual-edge (12 lines).
> 
> Add bus-width to the documentation so it can be used to select between the
> two connection scheme.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  .../devicetree/bindings/display/bridge/ti,tfp410.txt   | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
> index 3f903af93949..5ff4f64ef8e8 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
> @@ -18,7 +18,14 @@ This device has two video ports. Their connections are modeled using the OF
>  graph bindings specified in [1]. Each port node shall have a single endpoint.
>  
>  - Port 0 is the DPI input port. Its endpoint subnode shall contain a
> -  pclk-sample property and a remote-endpoint property as specified in [1].
> +  pclk-sample and bus-width property and a remote-endpoint property as specified
> +  in [1].
> +  - If pclk-sample is not defined, pclk-sample = 0 should be assumed for
> +    backward compatibility.
> +  - If bus-width is not defined then bus-width = 24 should be assumed for
> +    backward compatibility.
> +    bus-width = 24: 24 data lines are connected and single-edge mode
> +    bus-width = 12: 12 data lines are connected and dual-edge mode
>  
>  - Port 1 is the DVI output port. Its endpoint subnode shall contain a
>    remote-endpoint property is specified in [1].
> @@ -43,6 +50,7 @@ tfp410: encoder@0 {
>  
>  			tfp410_in: endpoint@0 {
>  				pclk-sample = <1>;
> +				bus-width = <24>;
>  				remote-endpoint = <&dpi_out>;
>  			};
>  		};

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux