On Mon, Jan 28, 2019 at 7:28 PM Liming Sun <lsun@xxxxxxxxxxxx> wrote: > > This commit adds the TmFifo platform driver for Mellanox BlueField > Soc. TmFifo is a shared FIFO which enables external host machine > to exchange data with the SoC via USB or PCIe. The driver is based > on virtio framework and has console and network access enabled. > > Reviewed-by: David Woods <dwoods@xxxxxxxxxxxx> > Signed-off-by: Liming Sun <lsun@xxxxxxxxxxxx> Please, go through this series taking into account review I just did for your another patch. On top of that, see recent (for few years I think) drivers what modern APIs they are using, e.g. devm_. -- With Best Regards, Andy Shevchenko