Thanks Andy. Sorry I had email issue earlier today. Not sure the reply was sent out or not. So sent another one just in case... v9 of this patch has been posted to address the 'devm_' comment. It also has the coding-style changes according to the comments I got for another patch. Regards, Liming > -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: Tuesday, January 29, 2019 5:07 PM > To: Liming Sun <lsun@xxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; David Woods > <dwoods@xxxxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxxxxx>; Darren Hart <dvhart@xxxxxxxxxxxxx>; Vadim Pasternak > <vadimp@xxxxxxxxxxxx>; devicetree <devicetree@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; > Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH v8 1/2] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc > > On Mon, Jan 28, 2019 at 7:28 PM Liming Sun <lsun@xxxxxxxxxxxx> wrote: > > > > This commit adds the TmFifo platform driver for Mellanox BlueField > > Soc. TmFifo is a shared FIFO which enables external host machine > > to exchange data with the SoC via USB or PCIe. The driver is based > > on virtio framework and has console and network access enabled. > > > > Reviewed-by: David Woods <dwoods@xxxxxxxxxxxx> > > Signed-off-by: Liming Sun <lsun@xxxxxxxxxxxx> > > > Please, go through this series taking into account review I just did > for your another patch. > > On top of that, see recent (for few years I think) drivers what modern > APIs they are using, e.g. devm_. > > -- > With Best Regards, > Andy Shevchenko
