On 25.01.2019 14:06, Russell King - ARM Linux admin wrote: > On Fri, Jan 25, 2019 at 12:55:10PM +0000, Carlo Caione wrote: >> SmartEEE, compatible with IEEE802.3az standard, is designed to include >> legacy MAC without EEE capability into the power saving system. SmartEEE >> is enabled by default configuration on AR8031 after power-on or hardware >> reset. >> >> Unfortunately this is proved causing issues for certain hw >> configurations. We add a quirk to optionally disable SmartEEE. > > It may be a good idea to detail what "certain hw configurations" are > and/or what the "issues" are, so it's easier to find this if/when > others encounter the same issue. > Question would also be whether the issue with SmartEEE occurs also if EEE isn't advertized and therefore not active. Then we could use the existing DT properties to flag broken EEE modes, see of_set_phy_eee_broken(). >> >> PATCH 3/3 depends on https://patchwork.kernel.org/patch/10781297/ >> >> >> Carlo Caione (3): >> net: phy: at803x: Introduce quirk to disable SmartEEE >> dt-bindings: net: at803x: Document at803x,smarteee-disabled property >> arm64: dts: imx8mq-evk: Disable SmartEEE >> >> .../devicetree/bindings/net/at803x.txt | 18 +++++++++++++++ >> arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 1 + >> drivers/net/phy/at803x.c | 22 +++++++++++++++++++ >> 3 files changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/at803x.txt >> >> -- >> 2.19.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> >
