On 1/25/19 7:37 AM, Rob Herring wrote:
> Since c32569e358ad ("regulator: Use of_node_name_eq for node name
> comparisons") Vivien reported the mc13892-regulator complaining about
> not being able to find regulators.
>
> This is because prior to that commit we used of_node_cmp() to compare
> the regulator array passed from mc13892_regulators down to
> mc13xxx_parse_regulators_dt() and they are all defined in uppercase
> letters by the MC13892_*_DEFINE* macros, whereas they are defined as
> lowercase in the DTS.
>
> Fix this by using a lowercase regulator name to match the DT node name.
>
> Fixes: c32569e358ad ("regulator: Use of_node_name_eq for node name comparisons")
> Reported-by: Vivien Didelot <vivien.didelot@xxxxxxxxx>
> Reported-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
Thanks, when I looked at it last night, it seems to me that you also
need to patch the following drivers:
drivers/regulator/88pm8607.c
drivers/regulator/da9052-regulator.c
drivers/regulator/max8997-regulator.c
drivers/regulator/s5m8767.c
since they all define their array of regulators using uppercase, and
then later match that using the same logic that
drivers/regulator/mc13xxx-regulator-core.c does.
--
Florian
