Hi, While you are making changes, here are a few more: On 1/2/19 5:39 PM, Nicolas Boichat wrote: > diff --git a/drivers/dma/mediatek/Kconfig b/drivers/dma/mediatek/Kconfig > index 27bac0b..1a523c87 100644 > --- a/drivers/dma/mediatek/Kconfig > +++ b/drivers/dma/mediatek/Kconfig > @@ -1,4 +1,15 @@ > > +config DMA_MTK_UART > + tristate "MediaTek SoCs APDMA support for UART" > + depends on OF && SERIAL_8250_MT6577 > + select DMA_ENGINE > + select DMA_VIRTUAL_CHANNELS > + help > + Support for the UART DMA engine found on MediaTek MTK SoCs. > + when SERIAL_8250_MT6577 is enabled, and if you want to use DMA, When > + you can enable the config. the DMA engine can only be used The > + with MediaTek SoCs. > + Also, use tabs to indent instead of spaces. The lines (tristate, depends, select, and help) should be indented with one tab. The help text lines should be indented with one tab + 2 spaces. > config MTK_HSDMA > tristate "MediaTek High-Speed DMA controller support" > depends on ARCH_MEDIATEK || COMPILE_TEST thanks, -- ~Randy