Hi Linus! Thank you for your input, I will refer to gpio.txt in the next version. Cheers, ---Lars > -----Original Message----- > From: Linus Walleij <linus.walleij@xxxxxxxxxx> > Sent: Sunday, December 30, 2018 21:00 > To: Lars Povlsen - M31675 <Lars.Povlsen@xxxxxxxxxxxxx> > Cc: Device Tree <devicetree@xxxxxxxxxxxxxxx>; Gregory Clement > <gregory.clement@xxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx> > Subject: Re: [PATCH v2] mips: gpio: mscc_sgpio: Add DT bindings > documentation > > On Thu, Dec 27, 2018 at 2:12 PM Lars Povlsen > <lars.povlsen@xxxxxxxxxxxxx> wrote: > > > mips: mscc_sgpio: Add DT bindings documentation > > > > This add device tree binding documentation for the MSCC serial > GPIO > > driver. > > > > v2 changes: > > - Added more device background info > > - Dropped "mscc,sgpio-bitcount" in favour of "ngpios" and "gpio- > ranges". > > - Elaborated "mscc,sgpio-ports" explanation > > > > > > Signed-off-by: Lars Povlsen <lars.povlsen@xxxxxxxxxxxxx> > > Overall looks good to me! > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > +Optional properties: > > +- ngpios: Set the number of GPIO's actually used. > > Just say see: gpio.txt > > Yours, > Linus Walleij
