Hi, On Mon, Dec 17, 2018 at 9:52 PM Sibi Sankar <sibis@xxxxxxxxxxxxxx> wrote: > >> @@ -39,13 +39,17 @@ on the Qualcomm Hexagon core. > >> - clocks: > >> Usage: required > >> Value type: <phandle> > >> - Definition: reference to the iface, bus and mem clocks to be > >> held on > >> - behalf of the booting of the Hexagon core > >> + Definition: reference to the list of 4 clocks for the modem > >> sub-system > >> + reference to the list of 8 clocks for the modem > >> sub-system > >> + on SDM845 SoCs > > > > The above is confusing because you don't list the SoCs that are > > supposed to use the 4 clocks. How about instead: > > > > Definition: reference to the clocks that match clock-names > > > > AFAIK, only the exceptions are captured. I am fine > with both, I'll wait for Bjorn/Rob's preference. Sure, waiting for Bjron / Rob to chime in sounds good. If you are going to document just the exception, though, IMO at least reword it. AKA: reference to the list of 8 clocks for the modem sub-system on SDM845 SoCs; reference to the list of 4 clocks for the modem sub-system on all other SoCs. ...the key being the "on all other" to make it clear. ...but I still like my original suggestion of using less prose and more lists, so hopefully Bjorn / Rob are OK with that. -Doug
