Hi Biju, On Thu, Dec 6, 2018 at 1:41 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > > Subject: Re: [PATCH v3 4/4] ARM: dts: iwg23s-sbc: Enable RTC > > On Thu, Dec 6, 2018 at 10:04 AM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > > > Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. > > > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > @@ -84,12 +84,30 @@ > > > clock-frequency = <20000000>; > > > }; > > > > > > +&i2c3 { > > > + pinctrl-0 = <&i2c3_pins>; > > > + pinctrl-names = "default"; > > > + > > > + status = "okay"; > > > + clock-frequency = <400000>; > > > + > > > + rtc@51 { > > > + compatible = "nxp,pcf85263"; > > > + reg = <0x51>; > > > > You might want to enable the optional interrupt: > > I have enabled this but unfortunately it is generating 100000 of gpio interrupts during boot. Oh, the DT bindings claim interrupt support hasn't been implement yet ;-) > The reason is, by default this pin is configured as function(Power on reset/at u-boot). > Currently there is no function available in kernel to convert a pin from function to gpio (Similar to the issue Fab is facing for display hot plug interrupt) > > May be we can add optional interrupt at a later stage, once we have a solution for converting pin from function to gpio. > > Please share your opinion on this. IC. In that case, please postpone describing the interrupt until the issue is fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds