On Mon, Sep 17, 2018 at 05:43:47AM +0000, Bhaskar Upadhaya wrote: > > >-----Original Message----- > >From: Shawn Guo <shawnguo@xxxxxxxxxx> > >Sent: Monday, September 3, 2018 7:27 AM > >To: Sudhanshu Gupta <sudhanshu.gupta@xxxxxxx> > >Cc: devicetree@xxxxxxxxxxxxxxx; Harninder Rai <harninder.rai@xxxxxxx>; > >Bhaskar Upadhaya <bhaskar.upadhaya@xxxxxxx>; stuart.yoder@xxxxxxx; > >Leo Li <leoyang.li@xxxxxxx>; oss@xxxxxxxxxxxx; linux-arm- > >kernel@xxxxxxxxxxxxxxxxxxx > >Subject: Re: [PATCH] arm64: dts: Add support for NXP LS1028A SoC > > > >On Wed, Aug 29, 2018 at 08:44:28PM +0530, Sudhanshu Gupta wrote: > >> From: Bhaskar Upadhaya <Bhaskar.Upadhaya@xxxxxxx> > >> > >> LS1028A contains two ARM v8 CortexA72 processor cores with 32 KB L1-D > >> cache and 48 KB L1-I cache > >> +&i2c0 { > >> + status = "okay"; > >> + > >> + pca9847@77 { > > > >Please have generic node name for the device. > is i2c-mux@77 ok ? There are some name suggestions in DeviceTree Specification [1]. Shawn [1] https://www.devicetree.org/