Hi, On Thursday 05 July 2018 11:25 AM, Tony Lindgren wrote: > * Faiz Abbas <faiz_abbas@xxxxxx> [180704 13:37]: >> After taking a second look at this thread, I don't see anything big to >> be modified. >> >> We both agree that "reset status bit in sysconfig register" is the quirk >> case which can be added once such an IP is discovered in ti-sysc. > > Yes agreed. > >> All I need to change is SYSC_OMAP4_SOFTRESET to SYSC_SOFT_RESET_SHIFT_0 >> for better readability and rebase it to the latest mainline. > > Let's not change SYSC_OMAP4_SOFTRESET as only the ti-sysc > driver needs to know that and it can be set based on the > compatible. Ok. > > How about replace ddata->cfg.quirks & SYSC_QUIRK_RESET_STATUS > test with just ddata->cfg.syss_mask test in your sysc_reset()? > > We still need to set SYSC_QUIRK_RESET_STATUS too for pdata > callbacks. Sure. Do reset in ti-sysc only if dt has the correct syss_mask. Rebasing and posting v4 soon. Thanks, Faiz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
