[PATCH V4 0/3] Microchip mcp25xxfd can controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Martin,

Am 14.06.2018 um 07:19 schrieb Martin Sperl:
> 
>> On 12.06.2018, at 16:38, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx> wrote:
>>
>> Hello Martin,
>>
>> this driver is huge... more than 4300 lines of code. That's maybe one
>> reason why it has not yet been reviewed. The driver includes a debugfs
>> interface and is also very verbose in general. I'm not sure if the
>> debugging code is really useful for the end user, but well, debugfs is
>> exactly for that purpose. What about splitting up the driver in a
>> subdirectory "mcp2517fd" into core, spi, debugfs, etc. Other opinions?
> 
> Splitting does unfortunately strip the compiler from the opportunity to
> Automatically inline code.
> 
> What I was thinking is maybe to split up the patch into:
> * basic functionality
> * debugfs
> * optimization code 
> * gpio lib related (already separated)
> * documentation comments

And Header files.

> Would that be helpful?

Other opinions?

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux