Quoting ilialin@xxxxxxxxxxxxxx (2018-03-20 07:18:57)
> > From: Stephen Boyd <sboyd@xxxxxxxxxx>
> >
> > > + struct clk_regmap *clkr = to_clk_regmap(hw);
> > > + struct clk_cpu_8996_mux *cpuclk = to_clk_cpu_8996_mux_hw(hw);
> > > + unsigned int mask = GENMASK(cpuclk->width + cpuclk->shift - 1,
> > > + cpuclk->shift);
> > > +
> > > + val = index;
> > > + val <<= cpuclk->shift;
> > > +
> > > + return regmap_update_bits(clkr->regmap, cpuclk->reg, mask,
> > > +val); }
> > > +
> > > +static int
> > > +clk_cpu_8996_mux_determine_rate(struct clk_hw *hw, struct
> > > +clk_rate_request *req) {
> > > + struct clk_cpu_8996_mux *cpuclk = to_clk_cpu_8996_mux_hw(hw);
> > > + struct clk_hw *parent = cpuclk->pll;
> > > +
> > > + if (!cpuclk->pll)
> > > + return -EINVAL;
> >
> > Does this happen?
>
> On successful probe it shouldn't. May I omit pointer checks in this case? Future maintenance ma y change the flow.
>
Yes please omit useless checks.
> >
> > > +
> > > + req->best_parent_rate = clk_hw_round_rate(parent, req->rate);
> > > + req->best_parent_hw = parent;
> >
> > Is the parent index always the same? Perhaps just call
> > clk_hw_get_parent_by_index() then instead of adding a pointer to the
> > clk_cpu_8996_mux.
> >
>
> >
> > > + },
> > > +};
> > > +
> > > +static const struct regmap_config cpu_msm8996_regmap_config = {
> > > + .reg_bits = 32,
> > > + .reg_stride = 4,
> > > + .val_bits = 32,
> > > + .max_register = 0x80210,
> > > + .fast_io = true,
> > > + .val_format_endian = REGMAP_ENDIAN_LITTLE,
> > > +};
> > > +
> > > +static const struct of_device_id match_table[] = {
> >
> > Move this next to driver structure and give it a more specific name.
>
> Will be changed in the next spin.
>
> >
> > > + { .compatible = "qcom-msm8996-apcc" },
> >
> > Bad compatible? Should be qcom,msm8996-apcc?
>
> The naming is per Rob Herring's requirement.
>
Hmm, maybe Rob made a typo?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
