Re: [PATCH V2 1/3] dt-binding: can: mcp25xxfd: document device tree bindings

[Rob Herring <robh@xxxxxxxxxx>]

On Fri, Jan 19, 2018 at 07:41:38AM +0000, kernel@xxxxxxxxxxxxxxxx wrote:
> From: Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
> 
> Add device-tree bindings for Microcip CanFD Controller mcp2517fd
> 
> Signed-off-by: Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
> 
> ---
> Changelog:
>   V1 -> V2: new more generic name based on feedback from microchip
>             cleanup of dt custom properties removing (most) gpio functions
> ---
>  .../bindings/net/can/microchip,mcp25xxfd.txt       | 29 ++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt b/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt
> new file mode 100644
> index 000000000000..691dd6220bd7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt
> @@ -0,0 +1,29 @@
> +* Microchip MCP2517 stand-alone CAN controller device tree bindings
> +
> +Required properties:
> + - compatible: Should be one of the following:
> +   - "microchip,mcp2517fd" for MCP2517fd.
> + - reg: SPI chip select.
> + - clocks: The clock feeding the CAN controller.
> + - interrupt-parent: The parent interrupt controller.
> + - interrupts: Should contain IRQ line for the CAN controller.
> +
> +Optional properties:
> + - vdd-supply: Regulator that powers the CAN controller.
> + - xceiver-supply: Regulator that powers the CAN transceiver.

> + - microchip,clock_out_div = <0|1|2|4|10>: Clock output pin divider
> +					   0 = Start of Frame output
> +					   default: 10
> + - microchip,clock_div2: bool: divide the internal clock by 2

s/_/-/

> + - gpio_opendrain: bool: enable open-drain for all pins (except cantx)

Needs a vendor prefix.

> +
> +Example:
> +	can0: can@1 {
> +		compatible = "microchip,mcp2515";
> +		reg = <1>;
> +		clocks = <&clk24m>;
> +		interrupt-parent = <&gpio4>;
> +		interrupts = <13 0x8>;
> +		vdd-supply = <&reg5v0>;
> +		xceiver-supply = <&reg5v0>;
> +	};
> --
> 2.11.0
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html