Re: [PATCH V2 3/3] can: mcp25xxfd: add gpiolib support for GPIO0/1 (aka. INT0/INT1)

[Rob Herring <robh@xxxxxxxxxx>]

On Fri, Jan 19, 2018 at 07:41:40AM +0000, kernel@xxxxxxxxxxxxxxxx wrote:
> From: Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
> 
> Add GPIOLIB support to mcp25xxfd.
> 
> Signed-off-by: Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
> 
> ---
> Changelog:
>   V1 -> V2: implemented GPIOLIB support as per feedback
> 
> ---
> .../bindings/net/can/microchip,mcp25xxfd.txt       |   2 +
>  drivers/net/can/spi/mcp25xxfd.c                    | 185 +++++++++++++++++++++
>  2 files changed, 187 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt b/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt
> index 691dd6220bd7..716b0a16ecb2 100644
> --- a/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt
> +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.txt
> @@ -7,6 +7,7 @@ Required properties:
>   - clocks: The clock feeding the CAN controller.
>   - interrupt-parent: The parent interrupt controller.
>   - interrupts: Should contain IRQ line for the CAN controller.
> + - gpio-controller: Marks the device node as a GPIO controller

This belongs in patch 1. The binding describes the h/w, not what a 
driver currently supports.

> 
>  Optional properties:
>   - vdd-supply: Regulator that powers the CAN controller.
> @@ -26,4 +27,5 @@ Example:
>  		interrupts = <13 0x8>;
>  		vdd-supply = <&reg5v0>;
>  		xceiver-supply = <&reg5v0>;
> +		gpio-controller;
>  	};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html